"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Martin Pieuchot <mpi@openbsd.org>
Subject:
Re: tog log & got-read-pack on the fly:
To:
gameoftrees@openbsd.org
Date:
Tue, 15 Oct 2019 11:53:12 +0200

Download raw body.

Thread
On 15/10/19(Tue) 11:11, Stefan Sperling wrote:
> On Fri, Oct 11, 2019 at 10:35:21AM +0200, Martin Pieuchot wrote:
> > On 11/10/19(Fri) 09:39, Stefan Sperling wrote:
> > > Here is a better diff which fixes the actual problem.
> > 
> > With this diff I don't see any prefetching, but the 'loading' periods are
> > shorter.
> 
> Do you think it should be committed, since it seems to be an improvement?
> Or do I wait until the following problem has been resolved as well?

It is indeed an improvement, the other problem seems unrelated, without
looking at the code, I'd say go for it.

> > Searching for an non-existing pattern still makes the tog freeze until
> > all commits are unpacked.
> 
> I forgot to ask earlier: Can the backspace key still abort the search
> in this case?

It doesn't.

> I am still unable to reproduce this. Is anyone else seeing this?

I've the openbsd git tree in /home/os/openbsd and I do

cd /home/os/openbsd/sys && tog log -c master .

Then I search for a weird pattern that doesn't match anything,  at that
moment the top bar says:

commit ........................................ /sys [1/XXX] searching...

And count until reaching the end commit:

commit d4ce8ef6e9b9ee3e216ced681f963a2ce288d25a /sys [1/78483] master, origin/ma

Then I can finally move around.