"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Tracey Emery <tracey@traceyemery.net>
Subject:
Re: got add recursion
To:
gameoftrees@openbsd.org
Date:
Sat, 23 Nov 2019 08:21:13 -0700

Download raw body.

Thread
On Sat, Nov 23, 2019 at 10:27:54AM +0100, Stefan Sperling wrote:
> On Fri, Nov 22, 2019 at 08:30:02AM -0700, Tracey Emery wrote:
> 1) We may want to encode the interaction of 'add -R' and ignored files
> in a regression test so we don't break it accidentally.
> 
> 2) 'svn add' also supports a --no-ignore option to allow recursive addition
> even for ignored files. Should we also add such an option: 'got add -R -I'?
> The docs could say something like:
>  -I	With -R, add files even if they match a 'got status' ignore pattern.

Hey Stefan? I thought you would have caught what I've forgotten, which
is in proper form for me! ... the TODO file! XD

The diff below fixes the TODO files, noting the changes above. For what
it's worth, I think it a good and valid option to include -I. It
maintains simplicity with improved functionality.

Thanks,

T

-- 

Tracey Emery

diff 3fd4eb5ab97dd3b1914bfe46f5b6a7bc1bd1ec81 /home/basepr1me/Documents/got/got
blob - 044aadf30b3ae798d851660a58e8dddd57a6b746
file + TODO
--- TODO
+++ TODO
@@ -11,7 +11,9 @@ lib:
 
 got:
 - 'histedit -c' prompts for log message even if there are no changes to commit
-- recursive addition: got add -R
+- recursive addition: got add -R -I, add files even if they match a 'got status'
+  ignore pattern.
+      improve regression testing by including ignore interactions
 - recursive removal: got rm -R
 
 tog: