On Sat, Jan 25, 2020 at 09:00:34AM -0700, Tracey Emery wrote:
> On Sat, Jan 25, 2020 at 11:14:36AM +0100, Stefan Sperling wrote:
> > Won't this change leave empty files around in /tmp? The temp files will
> > be closed but won't be removed from disk.
> 
> No files are visible to the filesystem with got_opentemp. The file is
> unlinked immediately.

Ah, of course. Sorry, I forgot about that.

> > I think leaving f1 or f2 as NULL and checking for NULL everywhere else
> > inside the diffreg code would be a better solution.
> >  
> 
> I agree. I'm just not going to get time this weekend to hack on that, so
> it is just a suggested temporary fix.

Yes, in that case feel free to commit it ASAP.