"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: changed paths in 'got log' and tog
To:
Matthieu Herrb <matthieu@herrb.eu>
Cc:
gameoftrees@openbsd.org, matthieu@openbsd.org
Date:
Tue, 5 May 2020 11:55:45 +0200

Download raw body.

Thread
On Tue, May 05, 2020 at 11:40:06AM +0200, Matthieu Herrb wrote:
> On Tue, May 05, 2020 at 09:55:35AM +0200, Stefan Sperling wrote:
> > On Tue, May 05, 2020 at 09:37:58AM +0200, Stefan Sperling wrote:
> > > Thank you for catching this. I forgot to clear the list of paths collected
> > > for the current commit when the current commit failed to match. So while
> >  
> > > Fixed in the new version of my patch below:
> > 
> > I found another problem: Performance was worse than expected because
> > diffing of file content was accidentally enabled during 'log -P'.
> > 
> > In this version of the patch we only diff tree entry IDs and skip diffing
> > file content, which is a lot faster and especially noticeable when
> > searching.
> 
> Thanks again. This version works as expected for me, and indeed
> searchine is much faster.

Great. This patch has been committed to the repo.