"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Raf Czlonka <rczlonka@gmail.com>
Subject:
Re: storing regress test data outside of /tmp
To:
Stefan Sperling <stsp@stsp.name>
Cc:
Christian Weisgerber <naddy@mips.inka.de>, gameoftrees@openbsd.org
Date:
Thu, 1 Oct 2020 20:42:25 +0100

Download raw body.

Thread 
On Thu, Oct 01, 2020 at 07:58:21PM BST, Stefan Sperling wrote:
> +++ regress/cmdline/common.sh
> [...]
> -	local testroot=`mktemp -p /tmp -d got-test-$testname-XXXXXXXX`
> +	local testroot=$(mktemp -d "$GOT_TEST_ROOT/got-test-$testname-XXXXXXXX")

Hi Stefan,

As much as I prefer $() vs. ``, the above looks odd when all below use
the latter style. Or perhaps... all of the below look odd ;^)

Regards,

Raf

> --- regress/cmdline/import.sh
> +++ regress/cmdline/import.sh
> -	local testroot=`mktemp -p /tmp -d got-test-$testname-XXXXXXXX`
> +	local testroot=`mktemp -d "$GOT_TEST_ROOT/got-test-$testname-XXXXXXXX"`
> [...]
> -	local testroot=`mktemp -p /tmp -d got-test-$testname-XXXXXXXX`
> +	local testroot=`mktemp -d "$GOT_TEST_ROOT/got-test-$testname-XXXXXXXX"`
> [...]
> -	local testroot=`mktemp -p /tmp -d got-test-$testname-XXXXXXXX`
> +	local testroot=`mktemp -d "$GOT_TEST_ROOT/got-test-$testname-XXXXXXXX"`
> [...]
> -	local testroot=`mktemp -p /tmp -d got-test-$testname-XXXXXXXX`
> +	local testroot=`mktemp -d "$GOT_TEST_ROOT/got-test-$testname-XXXXXXXX"`