"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Christian Weisgerber <naddy@mips.inka.de>
Subject:
Re: tog: tree view page up/down bugs
To:
gameoftrees@openbsd.org
Date:
Wed, 25 Nov 2020 14:04:02 +0100

Download raw body.

Thread
Stefan Sperling:

> On Wed, Nov 25, 2020 at 12:08:29AM +0100, Stefan Sperling wrote:
> > This should fix page-up/page-down behaviour in 'tog tree'.
> 
> My previous patch displayed a bogus .. parent directory entry after
> page-up was pressed in the root directory. Fixed here.

Something isn't right:
* In the got repository, start "tog tree lib".
* Move down until the first displayed entry is "blame.c".
* Move up again until "blame.c" is selected.
* Move up one more.  The selection now jumps to "..", skipping
  "arraylist.h".



PS:
While you're in tree_scroll_up(), please do
-       te = got_object_tree_get_entry(tree, 0);
+       te = got_object_tree_get_first_entry(tree);

-- 
Christian "naddy" Weisgerber                          naddy@mips.inka.de