On Sun, Nov 29, 2020 at 05:16:30PM +0100, Christian Weisgerber wrote:
> I'm hesitant to give this sort of backseat commentary, but various
> display-related functions in tog.c take an awful lot of parameters
> that are actually redundant.

tog.c is ugly in several ways. For example, some code sections use a
random mix of 'goto' and 'break' statements which effectively jump to
the same line. A lot of code sections have been copied and then modified,
and most duplicated logic was never extracted and unified again. 

tog was a copy-paste mess from the very beginning. It was initially written
as an interactive demo to show capabilities of the code in lib/libexec.
I paid more attention to the quality of the library code since that was
my main focus at the time.

Everyone, please feel invited to help with tidying up tog.c by eliminating
duplicated code sections and redundant helper functions that are called only
once, reducing function parameter lists, and generally making things more
consistent. This can be done incrementally with small patches here and there.
I might also go over tog.c soon in order to make some cosmetic changes.