"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: implement tog ref command
To:
Christian Weisgerber <naddy@mips.inka.de>, gameoftrees@openbsd.org
Date:
Tue, 24 Nov 2020 23:20:02 +0100

Download raw body.

Thread
On Tue, Nov 24, 2020 at 10:52:15PM +0100, Stefan Sperling wrote:
> On Mon, Nov 23, 2020 at 11:41:36PM +0100, Christian Weisgerber wrote:
> > * tog ref, /search for name, hit return, and tog is stuck with
> >   commit ........................................  [0/0] loading...
> >   This doesn't happen if you j/k move to a particular entry.
> 
> Thanks! Should be fixed by this patch:

I have decided to simply push this fix and all my 'tog ref' patches.
If there's anything left to fix, please let me know :)

> diff 2b8db489e8480a17bc3d329234cf659f4939adae /home/stsp/src/got
> blob - c0a85cd49ea9763190a0f4d11960ac7a8175b043
> file + tog/tog.c
> --- tog/tog.c
> +++ tog/tog.c
> @@ -2340,6 +2340,7 @@ done:
>  static const struct got_error *
>  show_log_view(struct tog_view *view)
>  {
> +	const struct got_error *err;
>  	struct tog_log_view_state *s = &view->state.log;
>  
>  	if (s->thread == NULL) {
> @@ -2347,6 +2348,15 @@ show_log_view(struct tog_view *view)
>  		    &s->thread_args);
>  		if (errcode)
>  			return got_error_set_errno(errcode, "pthread_create");
> +		if (s->thread_args.commits_needed > 0) {
> +			err = trigger_log_thread(view, 1,
> +			    &s->thread_args.commits_needed,
> +			    &s->thread_args.log_complete,
> +			    &s->thread_args.need_commits,
> +			    &s->thread_args.commit_loaded);
> +			if (err)
> +				return err;
> +		}
>  	}
>  
>  	return draw_commits(view, &s->last_displayed_entry,