"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: tog cleanup: simplify ref/tree_scroll function calls
To:
Christian Weisgerber <naddy@mips.inka.de>
Cc:
gameoftrees@openbsd.org
Date:
Tue, 1 Dec 2020 11:50:05 +0100

Download raw body.

Thread
On Tue, Dec 01, 2020 at 12:32:29AM +0100, Christian Weisgerber wrote:
> I missed that there is another pair, scroll_up() and scroll_down().
> These do need a "view" parameter--well, scroll_down() does--so
> should ref_scroll_*, tree_scroll_* also take one to keep all these
> functions similar?

Sure. And perhaps we could rename 'scroll_up/down' to log_scroll_up,
log_scroll_down since they operate on the log view. The current
names are historical; the log view was implemented first.