"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Christian Weisgerber <naddy@mips.inka.de>
Subject:
tog: reverse parameters to tree_view_visit_subtree()
To:
gameoftrees@openbsd.org
Date:
Tue, 1 Dec 2020 23:02:43 +0100

Download raw body.

Thread
  • Christian Weisgerber:

    tog: reverse parameters to tree_view_visit_subtree()

We always put the view or view state parameter first...

reverse tree_view_visit_subtree() parameters for consistency

ok?

diff 27c715dc9f65e8d714c7975e89247c353d545ecd 259041a74055b9771d1594b656e0f845bdfedccf
blob - 92120c7cde33afff3cb260a148050015f4d302d9
blob + 1752dad3eccced99c1284defaff88b7339c4ca8a
--- tog/tog.c
+++ tog/tog.c
@@ -1809,8 +1809,8 @@ open_diff_view_for_commit(struct tog_view **new_view, 
 }
 
 static const struct got_error *
-tree_view_visit_subtree(struct got_tree_object *subtree,
-    struct tog_tree_view_state *s)
+tree_view_visit_subtree(struct tog_tree_view_state *s,
+    struct got_tree_object *subtree)
 {
 	struct tog_parent_tree *parent;
 
@@ -1890,7 +1890,7 @@ tree_view_walk_path(struct tog_tree_view_state *s,
 		if (err)
 			break;
 
-		err = tree_view_visit_subtree(tree, s);
+		err = tree_view_visit_subtree(s, tree);
 		if (err) {
 			got_object_tree_close(tree);
 			break;
@@ -5416,7 +5416,7 @@ input_tree_view(struct tog_view **new_view, struct tog
 			    got_tree_entry_get_id(s->selected_entry));
 			if (err)
 				break;
-			err = tree_view_visit_subtree(subtree, s);
+			err = tree_view_visit_subtree(s, subtree);
 			if (err) {
 				got_object_tree_close(subtree);
 				break;
-- 
Christian "naddy" Weisgerber                          naddy@mips.inka.de