"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Christian Weisgerber <naddy@mips.inka.de>
Subject:
Re: tog: ref view must pass selected reference name to log view
To:
gameoftrees@openbsd.org
Date:
Fri, 4 Dec 2020 17:38:01 +0100

Download raw body.

Thread
Stefan Sperling:

> This patch is about hitting Enter on a reference displayed in a ref
> view, which will open a log view for the corresponding branch/tag.
> 
> The log view needs to told the name of the selected reference. Otherwise,
> keys such as Ctrl-L and B will load the branch pointed to by HEAD instead
> of staying in the selected branch/tag.

Yes, although that state is currently unreachable since a log view
opened from a ref view will self-destruct on ^L or B.

I think your fix is incomplete, log_tree_entry() has the same
problem.

-- 
Christian "naddy" Weisgerber                          naddy@mips.inka.de