On Sat, Dec 05, 2020 at 04:29:21PM +0100, Christian Weisgerber wrote:
> Stefan Sperling:
> 
> > This version fixes the above issues for me.
> > 
> > diff 3de29130c7ee88da6e0dd01d356a346c78659921 b3796c3623d628cac6cf2e78b080d7bb9ad3e341
> 
> Yes, that fixes all problems with < > in the diff view.
> 
> I think placing some select_displayed_commit() calls in input_log_view()
> and some further down in log_scroll_*() makes the logic harder to
> follow.
> 
> How about this, which puts all select_displayed_commit() calls into
> input_log_view()?

Yes, works for me. Ok.

> (It also turns select_displayed_commit into a poor name.  Not sure
> what to call it instead, set_selected_commit is already taken.)

I would suggest 'select_commit'. We could also tweak naming later, any time.