"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: make tog tree -c stick to current branch
To:
Christian Weisgerber <naddy@mips.inka.de>
Cc:
gameoftrees@openbsd.org
Date:
Sun, 6 Dec 2020 21:24:57 +0100

Download raw body.

Thread
On Sun, Dec 06, 2020 at 04:38:08PM +0100, Christian Weisgerber wrote:
> Stefan Sperling:
> 
> > > Remaining problem in this area: branch/tag information is losing
> > > stickiness on the tree -> log transition.
> > 
> > Fixed below.
> 
> > diff 56738456fd3d5c1928406bd347baedab29ce674a f039bcf33a8f964e16c59e2e66675bb6bb481658
> 
> > @@ -5546,6 +5566,7 @@ done:
> >  	free(repo_path);
> >  	free(cwd);
> >  	free(commit_id);
> > +	free(label);
> >  	if (commit)
> >  		got_object_commit_close(commit);
> >  	if (tree)
> 
> Here at the end of cmd_tree(), is there
> 
> +       if (ref)
> +               got_ref_close(ref);
> 
> missing?

Yes, thanks! I've committed this as a follow-up fix.
 
> Otherwise, ok.
> 
> -- 
> Christian "naddy" Weisgerber                          naddy@mips.inka.de
> 
>