"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: tog: child views don't resize properly
To:
Christian Weisgerber <naddy@mips.inka.de>
Cc:
gameoftrees@openbsd.org
Date:
Sun, 6 Dec 2020 23:20:25 +0100

Download raw body.

Thread
On Sun, Dec 06, 2020 at 10:30:25PM +0100, Christian Weisgerber wrote:
> Stefan Sperling:
> 
> > > It looks like child views in tog don't get passed KEY_RESIZE.
> > 
> > Nice catch. This appears to fix it.
> 
> Hmm.  No.
> 
> log -> tree	broken
> log -> ref	broken
> tree -> blame	ok
> tree -> log	ok
> tree -> ref	broken
> ref -> log	ok
> ref -> tree	broken
> 
> ?!?

Oh, sorry. I read over your bug report too fast.

I've only fixed this part of your bug report:
"a child log view does not load additional commits when the window grows."

Regarding this part:

"It's noticeable when you move the selection to the bottom,
then shrink the window, and the selection remains invisible."

Shrinking the window doesn't update selection in many cases.
This occurs even if the view isn't a child view. For instance, in 'tog tree'
if you move to the bottom entry and then shrink the window such that the
bottom entry is no longer visible, then the selection won't be updated.
If we want to fix that, it should probably to be fixed with a separate
patch per view; a combined patch that fixes all of it would be huge.