"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Christian Weisgerber <naddy@mips.inka.de>
Subject:
Unused parameters?
To:
gameoftrees@openbsd.org
Date:
Tue, 8 Dec 2020 23:38:12 +0100

Download raw body.

Thread
  • Christian Weisgerber:

    Unused parameters?

While trimming those overgrown parameter lists, I found a bunch of
unused parameters.  This gave me the idea to try...

CFLAGS += -Wunused-parameter -Wno-error=unused-parameter

$ grep -c warning: log  
224

Well, there are plenty of duplicates.  And there are a number of
unused parameters that are correct and required by the function
signature for callbacks, etc.  So we can't regularly build with
-Wunused-parameter, unless we want to sprinkle __unused around.
(Do we?)

I guess I could embark on another spree and try to clean this up.

Would this risk colliding with the Capsicum work?

-- 
Christian "naddy" Weisgerber                          naddy@mips.inka.de