"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Christian Weisgerber <naddy@mips.inka.de>
Subject:
Re: tog: fix display of lines ending in \r\n
To:
gameoftrees@openbsd.org
Date:
Thu, 10 Dec 2020 22:44:34 +0100

Download raw body.

Thread
Stefan Sperling:

> I plan to switch from fparseln(3) to getline(3) eventually, which
> will keep \n intact. (This patch was extracted out of a larger
> patch that converts tog to getline(3), which isn't finished yet.)

I see.  ok

> > It made me curious how got & tog deal with terminal control sequences
> > in commit messages and blobs.
> > * tog escapes them (where??), but gets confused about the line length.
> 
> Likely happens when tog converts to wide charactors so ncurses can
> display UTF-8 text? Non-UTF-8 data gets run through strvis in mbs2ws().

An ESC character is valid UTF-8.  I can't find any call to strvis()
or the like.

-- 
Christian "naddy" Weisgerber                          naddy@mips.inka.de