"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
"Todd C. Miller" <Todd.Miller@sudo.ws>
Subject:
Re: histedit: fix editing of log message comments
To:
Stefan Sperling <stsp@stsp.name>
Cc:
gameoftrees@openbsd.org
Date:
Tue, 15 Dec 2020 16:43:14 -0700

Download raw body.

Thread
On Wed, 16 Dec 2020 00:26:27 +0100, Stefan Sperling wrote:

> Turns out that 'got he' treats the log message as unmodified in this case,
> and copies the message as-is, keeping the comments intact. This behaviour
> was coded to prevent mistakes during 'got commit/import/tag', where the
> command will error out if the log message template is not modified. This is
> not appropriate for histedit because histedit is used to fix such mistakes.
>
> With the patch below applied, I could remove the comments with 'got he -m'.

Makes sense.  OK millert@

 - todd