"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: Exclusive log end
To:
Josh Rickmar <joshrickmar@outlook.com>
Cc:
gameoftrees@openbsd.org
Date:
Sun, 21 Mar 2021 21:38:20 +0100

Download raw body.

Thread
On Sun, Mar 21, 2021 at 04:11:34PM -0400, Josh Rickmar wrote:
> On Sun, Mar 21, 2021 at 08:31:45PM +0100, Stefan Sperling wrote:
> > I put this aside because I felt it added too much clutter to the UI.
> > But if you see a use for this then I am not against adding it.
> 
> Fair enough; I'd like to see the UI from becoming incomprehensible as
> well.  I actually don't need this (-l1 is usually good enough, and
> when it's not, it's probably some other small number that I easily
> remember).  I'll let others chime in if they also find it useful or
> not.

Our lack of a real use case for -X seems like a red flag.

Something else I don't really like about -X is that it can legitimately
produce empty output. For instance, 'got log -X main' in a fresh checkout
of 'main' will print nothing. While 'got log -x' will always produce
output, no matter what argument is passed.
Even the log -l option always produces output since 0 means 'no limit'.

I don't want to shoot the patch down. Perhaps there is value in this for
someone. I'm just explaining why I moved back on this idea which I
initially thought was great when it came to me.