"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Sebastien Marie <semarie@online.fr>
Subject:
Re: creating pack files
To:
gameoftrees@openbsd.org
Date:
Sat, 5 Jun 2021 10:47:32 +0200

Download raw body.

Thread
On Fri, Jun 04, 2021 at 02:54:42PM +0200, Stefan Sperling wrote:
> On Fri, Jun 04, 2021 at 01:08:02AM +0200, Stefan Sperling wrote:
> > This patch is my current state of 'gotadmin pack' work.
> 
> New version with some fixes:
> 
> - only pack referenced objects, drop support for packing anything loose
> - both including and excluding a ref is no longer an error (will be excluded)
> - tweak progress output
> - pack tag objects
> - ignore refs/got/*
> 
> I don't expect detailed code review since this patch is very large.
> It would be nice to get some test reports though.

patch applied on top of current

$ gotadmin pack -a
gotadmin: mkstemp: Permission denied

With ktrace:

 57079 gotadmin CALL  open(0x48c50fd2700,0xa02<O_RDWR|O_CREAT|O_EXCL>,0600<S_IRUSR|S_IWUSR>)
 57079 gotadmin NAMI  "/var/git/openbsd/got.git/objects/pack/packing.pack-xvkc3c"
 57079 gotadmin RET   open -1 errno 13 Permission denied

And it seems that "/var/git/openbsd/got.git" is unveiled with "r" only.

-- 
Sebastien Marie