"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Tracey Emery <tracey@traceyemery.net>
Subject:
Re: fds not getting properly closed
To:
Christian Weisgerber <naddy@mips.inka.de>
Cc:
gameoftrees@openbsd.org
Date:
Tue, 15 Jun 2021 16:14:33 -0600

Download raw body.

Thread
On Tue, Jun 15, 2021 at 11:59:04PM +0200, Christian Weisgerber wrote:
> Tracey Emery:
> 
> > I tracked this down to repo->gitdir_fd being opened in got_repo_open,
> > but never being closed in got_repo_close. The following is a small diff
> > that fixes the problem.
> 
> ok naddy
> 
> Can we slip this in while there?
> 
> --- lib/repository.c
> +++ lib/repository.c
> @@ -333,7 +333,7 @@ got_repo_get_cached_tag(struct got_repository *repo, s
>  	    &repo->tagcache, id);
>  }
>  
> -const struct got_error *
> +static const struct got_error *
>  open_repo(struct got_repository *repo, const char *path)
>  {
>  	const struct got_error *err = NULL;
> -- 
> Christian "naddy" Weisgerber                          naddy@mips.inka.de

Sure, ok. Makes sense!

-- 

Tracey Emery