"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Tracey Emery <tracey@traceyemery.net>
Subject:
Fix hang in regress
To:
gameoftrees@openbsd.org
Date:
Tue, 15 Jun 2021 16:22:17 -0600

Download raw body.

Thread
Hi,

I believe in most environments, VISUAL is checked before EDITOR, so, if
someone has this set, the test_commit_prepared_logmsg test will hang,
waiting for input in the background.

This fixes my hang. ok?

-- 

Tracey Emery

diff 991ff1aa4f423a1faea1bae0e85a913a88038309 /home/tracey/src/got
blob - 3956dc0289b56e9ce806eab6702d0522b243de79
file + regress/cmdline/commit.sh
--- regress/cmdline/commit.sh
+++ regress/cmdline/commit.sh
@@ -1380,7 +1380,7 @@ sed -i 's/foo/bar/' "\$1"
 EOF
 	chmod +x $testroot/editor.sh
 
-	(cd $testroot/wt && env EDITOR="$testroot/editor.sh" \
+	(cd $testroot/wt && env VISUAL="$testroot/editor.sh" \
 		got commit -F "$testroot/logmsg" > $testroot/stdout)
 
 	local head_rev=`git_show_head $testroot/repo`