"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Christian Weisgerber <naddy@mips.inka.de>
Subject:
Re: format log messages more efficiently
To:
gameoftrees@openbsd.org
Date:
Mon, 2 Aug 2021 18:35:03 +0200

Download raw body.

Thread
Stefan Sperling:

> This repo exposes several problems in our code. The first one is that
> asprintf() is called for every line while preparing a log message for
> display, which causes many unnecessary temporary allocations.
> 
> The patch below fixes this by rewriting got_object_commit_get_logmsg()
> such that only one memory allocation is made when creating a pretty
> version of a log message.

ok naddy@

-- 
Christian "naddy" Weisgerber                          naddy@mips.inka.de