"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Christian Weisgerber <naddy@mips.inka.de>
Subject:
Re: Regress failures: regress, histedit
To:
gameoftrees@openbsd.org
Date:
Sat, 28 Aug 2021 16:49:56 +0200

Download raw body.

Thread
Christian Weisgerber:

> It's about 00:30 here (UTC+2) and the rebase and histedit regression
> tests are failing _right now_ for me with various differences like
> this one:
> 
> - 2021-08-27 flan_hacker  committing more changes on newbranch
> + 2021-08-28 flan_hacker  committing more changes on newbranch

After moving my time zone to Pacific/Kiritimati (UTC+14), I've been
able to examine this in a more convenient time window.

The failures are in
  rebase.sh:   test_rebase_basic()
  histedit.sh: test_histedit_no_op()

rebase -l and histedit -l don't return the expected output.
Both use the same code path in print_backup_ref().

The test specifically expects all times to be in UTC.

There are three timestamps involved in print_backup_ref().
print_commit() outputs UTC.  However, get_commit_brief_str() prints
the committer time using localtime_r().  Hmmm.

$ got rebase -l
-----------------------------------------------
commit 723e21323f485af395d566b0ee6dd21f9cfe0d6a (formerly newbranch)
from: Flan Hacker <flan_hacker@openbsd.org>
date: Sat Aug 28 13:50:22 2021 UTC
 
 committing more changes on newbranch
 
has become commit a6b18608d206750186e13e6c75cf68160e0eaa62 (newbranch)
 2021-08-29 flan_hacker  committing more changes on newbranch
history forked at 8ff114222752ea5e194f2551fac9d48119a11285
 2021-08-29 flan_hacker  adding the test tree

-- 
Christian "naddy" Weisgerber                          naddy@mips.inka.de