"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Christian Weisgerber <naddy@mips.inka.de>
Subject:
Make "got branch -d" print reference name and value
To:
gameoftrees@openbsd.org
Date:
Sat, 4 Sep 2021 16:06:44 +0200

Download raw body.

Thread
make "got branch -d" print reference name and value

Currently, "branch -d" operates silently.  With this change we match
the behavior of "ref -d" and "rebase -X"/"histedit -X" that print
sufficient information to allow recovering if the user fat-fingered
something.

I was about to copy-paste the code from delete_ref() into
delete_branch(), but I think we can just call delete_ref().

OK?

diff refs/heads/main refs/heads/delete_branch
blob - a0e7e05af0e93f5a85e8a6117f1adbd8844b60db
blob + 2b613840d91ea1cbd89ec43808bfa0f9f99fac58
--- got/got.c
+++ got/got.c
@@ -5773,7 +5773,7 @@ delete_branch(struct got_repository *repo, struct got_
 		goto done;
 	}
 
-	err = got_ref_delete(ref, repo);
+	err = delete_ref(repo, ref);
 done:
 	if (ref)
 		got_ref_close(ref);
-- 
Christian "naddy" Weisgerber                          naddy@mips.inka.de