"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: Pointer sign warnings
To:
Christian Weisgerber <naddy@mips.inka.de>
Cc:
gameoftrees@openbsd.org
Date:
Tue, 28 Sep 2021 20:31:14 +0200

Download raw body.

Thread
On Tue, Sep 28, 2021 at 08:13:59PM +0200, Christian Weisgerber wrote:
> Christian Weisgerber:
> 
> > There are, however, a bunch of low-hanging fruits:
> 
> (2) fix unsigned/signed char mismatch in parse.y

ok

>  
> diff 2a0e76d42d84db849f8bf014205a78079a781ddb 430f73133f7f6c6c095bfcb6ec3aac1435ba1062
> blob - 6c97b602a6967eed43b39a0b6cd54fa267cebffe
> blob + ba25a756cb8a903c2e0660038d5c673fbf1c478a
> --- libexec/got-read-gotconfig/parse.y
> +++ libexec/got-read-gotconfig/parse.y
> @@ -503,10 +503,10 @@ parseport(char *port, long long *pn)
>  int
>  yylex(void)
>  {
> -	unsigned char	 buf[8096];
> -	unsigned char	*p, *val;
> -	int		 quotec, next, c;
> -	int		 token;
> +	char	 buf[8096];
> +	char	*p, *val;
> +	int	 quotec, next, c;
> +	int	 token;
>  
>  top:
>  	p = buf;
> 
> -- 
> Christian "naddy" Weisgerber                          naddy@mips.inka.de
> 
>