"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: plug memleaks in got-fetch-pack and got-send-pack
To:
Christian Weisgerber <naddy@mips.inka.de>
Cc:
gameoftrees@openbsd.org
Date:
Thu, 7 Oct 2021 17:27:41 +0200

Download raw body.

Thread
On Thu, Oct 07, 2021 at 04:43:38PM +0200, Christian Weisgerber wrote:
> Stefan Sperling:
> 
> > > Good point. Looking at this I realized that got_gitproto_parse_refline()
> > > should be initializing its output arguments to make things easier for
> > > callers. Except the capabilities string, which is only parsed once,
> > > and which should be freed as well if it occurs more than once.
> > 
> > And one more time with proper error checking in got_gitproto_parse_refline().
> 
> But that is already done in tokenize_refline().

Right, this seems redundant then. I'll commit the previous patch. Thanks!