"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: tog: C-n/C-p to scroll by line
To:
Omar Polo <op@omarpolo.com>
Cc:
gameoftrees@openbsd.org
Date:
Sat, 16 Oct 2021 21:27:15 +0200

Download raw body.

Thread
On Sat, Oct 16, 2021 at 06:10:57PM +0200, Omar Polo wrote:
> Hello,
> 
> The attached patch adds C-n and C-p bindings to the various tog views to
> scroll by one line up and down.
> 
> I don't intend to replicate the whole set of Emacs keybindings inside
> tog, but I think it's worth to include at least some like control-n and
> control-p.  I've been using tog patched this way for a while and can't
> imagine going back ;-)  muscle memory is hard to defeat.

Fine with me.

> +	case CTRL('P'):

> +	case CTRL('N'):

Any specific reason for using upper-case P and N instead of lower-case
p and n? Existing code with the CTRL() macro is using lower-case letters.