"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: fix tog diff view with "Binary files differ"
To:
gameoftrees@openbsd.org
Date:
Thu, 6 Jan 2022 00:29:10 +0100

Download raw body.

Thread
On Thu, Jan 06, 2022 at 12:17:30AM +0100, Stefan Sperling wrote:
> When a diff contains a line of the form:
> 
> Binary files A and B differ
> 
> then scrolling across that line with tog can mess up the display.
> 
> In cases I have observed, the first two lines of the tog diff view
> change from something like this:
> 
>   [22/81] diff $commithash1 $commithash2
>   Binary files a/b/c and d/e/f differ
>   blob - $blob_hash1
> 
> To this after scrolling down one line:
> 
>   [23/81] diff $commithash1 $commithash2
>   /e/f differ
>   blob - $blob_hash1
>
> Scrolling down further now has a funny effect where the first line
> of the display keeps showing a portion of the former line.
 
For the curious, this repository contains commits which show the
problem: https://forge.softwareheritage.org/source/swh-loader-cvs
For example, try: tog diff 509ac801 beb7fc8a