On Fri, Mar 18, 2022 at 04:24:00PM +0100, Christian Weisgerber wrote:
> The got_errors[] array, which maps error codes to messages, is
> weirdly placed.
> 
> Currently it is defined as a static variable in include/got_error.h.
> In principle, every compiled file that includes got_error.h will
> get its own private copy of got_errors[].  In practice, the compiler
> will silently drop the table from the generated code if it isn't
> referenced.  And only lib/error.c actually references it.
> 
> I think got_errors[] should move into error.c.  The only reason I
> can think of for it to be in got_errno.h is to serve as a reminder
> to add an error message when adding new error codes, but that seems
> a poor justification for such an oddity.
> 

Fine with me.