Mark Jamsek <mark@jamsek.com> wrote:
> On 22-06-16 10:09am, Omar Polo wrote:
> > Mark Jamsek <mark@jamsek.com> wrote:
> > > horizontal scroll for diff, blame, and log views:
> > 
> > this is really cool!  thanks for working on it.  I particularly like how
> > the log view scrolls.
> > 
> > one nitpick regarding the manpage:
> > 
> > > diff 1b1b91abdb4cd380995e3542580daa8700d93f6f /home/mark/src/git/got
> > > blob - 56d92245cc73778b494f7d494ab0ad7560d3fab6
> > > file + tog/tog.1
> > > --- tog/tog.1
> > > +++ tog/tog.1
> > > @@ -104,6 +104,14 @@ are as follows:
> > >  Move the selection cursor down.
> > >  .It Cm Up-arrow, k, <, Comma, Ctrl-p
> > >  Move the selection cursor up.
> > > +.It Cm Right-arrow, l
> > > +Scroll log message field to the right.  Log message moves left on the screen.
> > > +.It Cm Left-arrow, h
> > > +Scroll log message field to the left.  Log message moves right on the screen.
> > 
> > after a sentence we should break the line.  You can check common issues
> > like this one by using the -Tlint flag of man/mandoc:
> > 
> > 	% man -Tlint -l tog.1
> > 	man: tog.1:108:41: WARNING: new sentence, new line
> > 	man: tog.1:110:40: WARNING: new sentence, new line
> > 	...
> > 
> > often you can ignore the STYLE-level errors, at least for things that
> > are not part of the base system.
> 
> Thanks, Omar! I'll make a note to do that in future.
> 
> Here's a patch with the linebreaks:

yep, that's perfect, thanks!

ok op@

> diff a75b3e2dd76c9392eb52ae19ef339a13f32eb821 /Users/mark/Library/Mobile Documents/com~apple~CloudDocs/src/got-hscroll
> blob - d5a5e0f4283bac082f8b81806c3cfe6a15f89867
> file + tog/tog.1
> --- tog/tog.1
> +++ tog/tog.1
> @@ -105,9 +105,11 @@ Move the selection cursor down.
>  .It Cm Up-arrow, k, <, Comma, Ctrl-p
>  Move the selection cursor up.
>  .It Cm Right-arrow, l
> -Scroll log message field to the right.  Log message moves left on the screen.
> +Scroll log message field to the right.
> +Log message moves left on the screen.
>  .It Cm Left-arrow, h
> -Scroll log message field to the left.  Log message moves right on the screen.
> +Scroll log message field to the left.
> +Log message moves right on the screen.
>  .It Cm $
>  Scroll log message field to the rightmost position.
>  .It Cm 0
> @@ -228,9 +230,11 @@ Scroll down.
>  .It Cm Up-arrow, k, Ctrl-p
>  Scroll up.
>  .It Cm Right-arrow, l
> -Scroll view to the right.  Diff output moves left on the screen.
> +Scroll view to the right.
> +Diff output moves left on the screen.
>  .It Cm Left-arrow, h
> -Scroll view to the left.  Diff output moves right on the screen.
> +Scroll view to the left.
> +Diff output moves right on the screen.
>  .It Cm $
>  Scroll view to the rightmost position.
>  .It Cm 0
> @@ -307,9 +311,11 @@ Move the selection cursor down.
>  .It Cm Up-arrow, k, Ctrl-p
>  Move the selection cursor up.
>  .It Cm Right-arrow, l
> -Scroll view to the right.  File output moves left on the screen.
> +Scroll view to the right.
> +File output moves left on the screen.
>  .It Cm Left-arrow, h
> -Scroll view to the left.  File output moves right on the screen.
> +Scroll view to the left.
> +File output moves right on the screen.
>  .It Cm $
>  Scroll view to the rightmost position.
>  .It Cm 0