"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: tog: fix horizontal scrolling of unicode in the diff view
To:
Omar Polo <op@omarpolo.com>
Cc:
gameoftrees@openbsd.org
Date:
Thu, 16 Jun 2022 17:46:24 +0200

Download raw body.

Thread
On Thu, Jun 16, 2022 at 04:49:03PM +0200, Omar Polo wrote:
> Stefan Sperling <stsp@stsp.name> wrote:
> > Fix horizontal scrolling of unicode in the diff view. This makes
> > the diff in my ja.git test repo scroll properly.
> > 
> > Turns out we need another output parameter in format_line() for
> > this case. draw_file() needs to know the width of the unscrolled
> > version of each line in order to set view->maxx correctly.
> > 
> > ok?
> 
> yep, it reads fine.

As you noted, this patch breaks the '$' key in the diff view.

I will need some more time to investigate and find a proper fix.