"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: fix overzelous sanity check in got_privsep_get_imsg_obj
To:
Omar Polo <op@omarpolo.com>
Cc:
gameoftrees@openbsd.org
Date:
Sat, 18 Jun 2022 18:13:28 +0200

Download raw body.

Thread
On Sat, Jun 18, 2022 at 05:07:30PM +0200, Omar Polo wrote:
> and eventually we may want to zero also the other structs?  most of
> these only have one or two fields, but others like the delta have a
> number of them.
> 
> every one of them has all the fields always initialized thought, only
> got_privsep_send_obj was optionally initializing some.

ok

Even where the memset is redundant today, without it there is a potential
for things to blow up like they did in the openbsd wireless stack before
7.1 001_wifi.patch. So, yes, please add them.