On 22-06-30 01:06am, Mark Jamsek wrote:
> On 22-06-29 04:53pm, Stefan Sperling wrote:
> > On Thu, Jun 30, 2022 at 12:17:59AM +1000, Mark Jamsek wrote:
> > > On 22-06-26 11:08pm, Mark Jamsek wrote:
> > > > The below diff adds support for horizontal splits in tog.
> > > > 
> > > Also in the diff, echo count prefix to the bottom left of the _terminal_
> > > screen irrespective of the split or active window (rather than the
> > > bottom left of the top horizontal or right vertical split.  I haven't
> > > changed the location of the search "/" prompt except for in hsplits;
> > > I thought I'd see what the consensus is first. At present, we draw the
> > > search prompt in the bottom left of the active view when in a vsplit. So
> > > we can either continue this behaviour with hsplits, or always echo to
> > > the absolute bottom left of the screen. I wanted to get a feel for what
> > > they both look like, but I don't feel strongly one way or the other.
> > > I suppose it feels a little surprsing to have it in different locations
> > > but that's subjective.
> > 
> > This patch is a great start. I would be fine with this going in as it is,
> > with further tweaks to be expected on top later. For example, horizontal
> > splitting should work via tog log -> tree -> blame just like it does
> > for tog tree -> blame. That is the most urgent usability issue I can see.
> 
> Thanks, Stefan!
> 
> And, yes, there's still a lot more work I have planned here.
> Specifically, expand hsplit support to all parent/child views, and
> keymaps for split type and size--assuming this is ok?
> 

Also, I plan to send this in two commits if there're no objections; I'd
like to split the log movement refactoring from the hsplit code.

-- 
Mark Jamsek <fnc.bsdbox.org>
GPG: F2FF 13DE 6A06 C471 CA80  E6E2 2930 DC66 86EE CF68