"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: add signer_id option to got.conf(5)
To:
Josh Rickmar <openbsd+lists@zettaport.com>
Cc:
gameoftrees@openbsd.org
Date:
Tue, 5 Jul 2022 18:34:38 +0200

Download raw body.

Thread
On Tue, Jul 05, 2022 at 11:06:21AM -0400, Josh Rickmar wrote:
> On Tue, Jul 05, 2022 at 04:55:57PM +0200, Stefan Sperling wrote:
> > On Tue, Jul 05, 2022 at 10:51:01AM -0400, Josh Rickmar wrote:
> > > ok?
> > 
> > Needs a regress test :)
> > 
> 
> same patch with a test

Looks good, OK.
I would probably test getting a key from got.conf first, and then
test -s in combination with the key set in got.conf, to ensure that
the config file setting is indeed overriden by the command line.
But what you've done is also a valid test case.