"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Josh Rickmar <openbsd+lists@zettaport.com>
Subject:
Re: use correct pipe ends on linux
To:
Stefan Sperling <stsp@stsp.name>
Cc:
gameoftrees@openbsd.org
Date:
Wed, 6 Jul 2022 09:22:28 -0400

Download raw body.

Thread
On Wed, Jul 06, 2022 at 03:13:55PM +0200, Stefan Sperling wrote:
> On Wed, Jul 06, 2022 at 08:23:24AM -0400, Josh Rickmar wrote:
> > > But verifying tags with Git does not work yet, which causes a test failure.
> > > 
> > > $ git -v 1.0.0 >/dev/null
> > > error: no signature found
> > > $ 
> > 
> > Is this with Git 2.34.0 or newer?  Earlier versions don't support SSH
> > signatures.
>  
> That explains it then. This system has 2.25.1.
> 
> Should the test try to skip this step if the version of Git is too old?

Yeah, seems reasonable.  It should also skip if built with OpenSSH
version 8.7.  From https://lore.kernel.org/git/xmqq8rxpgwki.fsf@gitster.g/:

 * In addition to GnuPG, ssh public crypto can be used for object and
   push-cert signing.  Note that this feature cannot be used with
   ssh-keygen from OpenSSH 8.7, whose support for it is broken.  Avoid
   using it unless you update to OpenSSH 8.8.

I'm not aware of a way to test for this support from Git itself.  I
guess we'll have to parse the version strings? :(