On Tue, Jul 19, 2022 at 12:31:23AM +0200, Omar Polo wrote:
> @@ -548,24 +548,23 @@ import_progress(void *arg, const char *path)
>  	return NULL;
>  }
>  
> -static int
> +static const struct got_error *
>  valid_author(const char *author)
>  {
> -	/*
> -	 * Really dumb email address check; we're only doing this to
> -	 * avoid git's object parser breaking on commits we create.
> -	 */

Please leave the part of this comment intact which says that these
rules were made up by Git, not by us. Our own parser doesn't care
how the author/committer name is formatted.

> blob - bde78fabea00a9c132a5ec2ea937fc0665428986
> file + lib/error.c
> --- lib/error.c
> +++ lib/error.c
> @@ -159,8 +159,7 @@ static const struct got_error got_errors[] = {
>  	{ GOT_ERR_STAGED_PATHS, "work tree contains files with staged "
>  	    "changes; these changes must be committed or unstaged first" },
>  	{ GOT_ERR_PATCH_CHOICE, "invalid patch choice" },
> -	{ GOT_ERR_COMMIT_NO_EMAIL, "commit author's email address is required "
> -	    "for compatibility with Git" },
> +	{ GOT_ERR_BAD_EMAIL, "invalid email address" },

For the same reason, I would prefer to keep this error as it was.