"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: tog: open log view of annotated line
To:
Mark Jamsek <mark@jamsek.com>
Cc:
gameoftrees@openbsd.org
Date:
Wed, 20 Jul 2022 10:35:27 +0200

Download raw body.

Thread
On Wed, Jul 20, 2022 at 04:24:35PM +1000, Mark Jamsek wrote:
> Relatedly, should this become convention; that is, uppercase alpha
> keymaps used to open other views? So, besides l := L in the tree view,
> t := T in the log and ref views; and r := R in the log and tree views.

That could make sense, yes. T and R are not used yet, and leaving small
t and r free for other functions might be useful later.

> Revised and rebased diff with suggested changes below. This makes
> log_annotated_line() much simpler.  Tests with your fix suggest it's
> working as intended.

Works well indeed. ok stsp@