"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: got send progress
To:
Florian Obser <florian@narrans.de>
Cc:
gameoftrees <gameoftrees@openbsd.org>
Date:
Thu, 21 Jul 2022 18:19:36 +0200

Download raw body.

Thread
On Thu, Jul 21, 2022 at 05:46:59PM +0200, Florian Obser wrote:
> I can't quite figure out if there is a case where we are not updating
> progress even with the fix. Maybe we can just drop bytes_sent_cur and
> always update, that's what the code is currently doing anyway.

Your fix is fine. ok stsp@

Progress looks the same as before because libexec/got-send-pack uses
rate-limiting for the progress reports it sends via imsg. These reports
are spaced 500 msec apart. In your testing some amount of bytes will
always have been sent when another 500 msec have elapsed.