"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Mark Jamsek <mark@jamsek.com>
Subject:
Re: tog: populate new child log lines when switching split
To:
Omar Polo <op@omarpolo.com>
Cc:
gameoftrees@openbsd.org
Date:
Fri, 22 Jul 2022 13:43:13 +1000

Download raw body.

Thread
On 22-07-21 11:38am, Omar Polo wrote:
> Mark Jamsek <mark@jamsek.com> wrote:
> > -----------------------------------------------
> > commit b1cabdf3e6c4ae8f321b764cb0fcc30453f89b3c (fix/logvsplit)
> > from: Mark Jamsek <mark@jamsek.dev>
> > date: Wed Jul 20 14:07:31 2022 UTC
> > 
> >  tog: populate new child view log lines when switching split
> > 
> >  When switching a newly opened child log view from a h- to a v-split, the
> >  new log lines are empty:
> >    $ tog blame CHANGES
> >    S  # toggle hsplit
> >    L  # open log view
> >    S  # switch to vsplit
> >    *new log lines are empty*
> > 
> >  When switching splits, call the recently added resize_log_view() method to do
> >  the work and populate new lines if needed.
> 
> ok op@
> 
> (not sure if mentioning the repro in the commit message helps but i'm
> bad a writing those so don't mind me :-)

Thanks, op!

I removed the repro :)

-- 
Mark Jamsek <fnc.bsdbox.org>
GPG: F2FF 13DE 6A06 C471 CA80  E6E2 2930 DC66 86EE CF68