On Sat, Jul 23, 2022 at 06:25:18PM +0200, Omar Polo wrote:
> three small nits, no functional changes intended.
> 
>  - pack_fds is unused
>  - the worktree is never closed
>  - we can get away without the wpath, proc, exec and sendfd promises
> 
> The pledge promises can be safely removed because `got info' only looks
> at the fileindex, it doesn't need to call the libexec helpers, nor tries
> to create it AFAICS.  if called with zero paths it could also drop the
> "rpath" promise too eventually.
> 
> There is no regress for info, but it seems to work fine (both as `got
> info' and as `got info paths...')

ok stsp@

> P.S.: should `got info' print also the selected author?  to play with
> the GOT_IGNORE_GITCONFIG env i've made `got info' to print the author,
> that's why i noticed this nits, but maybe it could be useful to debug
> the setup if `got info' would print also the selected author?

Yes, that would be fine.