"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: tog: keymaps to navigate to prev/next file/hunk in the diff
To:
Mark Jamsek <mark@jamsek.com>
Cc:
gameoftrees@openbsd.org
Date:
Mon, 1 Aug 2022 14:36:56 +0200

Download raw body.

Thread
> I think this makes more sense too tbh. With the line type index, we can
> add key maps to jump to, for example, the file changeset or log message,
> but this doesn't exist in tog diff when the requested artifacts are not
> sequential commits. A no-op would be preferable in this case to erroring
> out.
> 
> Revised diff now no-ops if we don't find the requested type.

Thanks, ok stsp@

> btw, I can live with them, but I'm not super happy with () to jump to
> the prev/next file: now that we have KJ added to ,. to go to the
> prev/next commit in the diff and blame views, what do you think about
> remapping <> to go to the prev/next file?

Yes, we can consider changing this.

The <> and ,. bindings are currently only used by the log and diff views.
It's not a big loss if <> were repurposed for other use.

KJ don't exactly behave like <>, which is probably unintentional.
In the log view KJ don't do anything if no diff view is open, whereas
pressing <> or ., moves the cursor regardless.