"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: some nits for diff.git
To:
Omar Polo <op@omarpolo.com>
Cc:
gameoftrees@openbsd.org
Date:
Tue, 2 Aug 2022 22:49:48 +0200

Download raw body.

Thread
On Tue, Aug 02, 2022 at 08:09:09PM +0200, Omar Polo wrote:
> spotted while reading the code / playing with the tests.  in order:
> 
>  - make diff_atom_hash_update private to diff_atomize_text.c;  it's
>    debatable but i think it doesn't belong to the public diff_main.h header
> 
>  - reuse diff_atom_hash_update instead of handrolling it.  no-op change
>    but avoid issues if we ever want to change the hashing.
> 
>  - optionally look for diff in obj/
> 
>  - less chatty output: avoids some printing to stderr (like "gpatch not
>    found" or "rm: errors: No such file or directory").  I'm also
>    moving from which(1) to the command built-in.
> 
> ok?

ok stsp@