"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: Group options in accordance with style(9)
To:
gameoftrees@openbsd.org
Date:
Tue, 16 Aug 2022 11:15:56 +0200

Download raw body.

Thread 
On Mon, Aug 15, 2022 at 06:40:22PM -0400, Josiah Frentsos wrote:
> diff ace4e41cf157fb25a0b4924a7d9490ced58e12a1 79b6c20a80ee36b0e7de31e296a61ec2d2ddce6a

Committed, thanks!
Grouping all single-letter options together is a particularly nice
improvement. It makes the usage strings a lot more readable.

There was a trivial regress test failure with your patch applied.
I have already fixed this in a follow-up commit:

==== revert ====
./revert.sh -q -r "/tmp"
--- /tmp/got-test-revert_no_arguments-yjT7iZiz/stderr.expected  Tue Aug 16 11:08:17 2022
+++ /tmp/got-test-revert_no_arguments-yjT7iZiz/stderr   Tue Aug 16 11:08:17 2022
@@ -1 +1 @@
-usage: got revert [-p] [-F response-script] [-R] path ...
+usage: got revert [-pR] [-F response-script] path ...
test failed; leaving test data in /tmp/got-test-revert_no_arguments-yjT7iZiz