"GOT", but the "O" is a cute, smiling sun Index | Thread

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: tog: ensure stdin is a tty
To:
Omar Polo <op@omarpolo.com>
Cc:
Mark Jamsek <mark@jamsek.com>, Game of Trees <gameoftrees@openbsd.org>
Date:
Tue, 6 Sep 2022 09:49:12 +0200

Download raw body.

On Mon, Sep 05, 2022 at 08:13:57PM +0200, Omar Polo wrote:
> On 2022/09/06 04:07:39 +1000, Mark Jamsek <mark@jamsek.com> wrote:
> > On 22-09-03 04:55PM, Omar Polo wrote:
> > > given the place where that check is, I'd go with an
> > > 
> > > 	errx(1, "stardand input is not a tty");
>                  ^^^^^^^^
> > diff refs/heads/main refs/heads/fix/tty
> > commit - 3d8e0c5ede1a5654397b63a9f483d875543527d5
> > commit + 7f04ea5dca27cc3e9751803d572f6792dde836d1
> > blob - 9d57af707725df8ed20c18c242b8359ad3a3270c
> > blob + 5b813c5e0de32f5883d2349934fb4b0280daa2ed
> > --- tog/tog.c
> > +++ tog/tog.c
> > @@ -8478,6 +8478,9 @@ main(int argc, char *argv[])
> >  	};
> >  	char *diff_algo_str = NULL;
> >  
> > +	if (!isatty(STDIN_FILENO))
> > +		errx(1, "stardand input is not a tty");
>                          ^^^^^^^^
> 
> wops, the typo wasn't a requirement! :D

Mark is just being meticulous as usual :)

> ok for me!

ok for me, too