On 2022/09/11 14:02:06 +1000, Mark Jamsek <mark@jamsek.com> wrote:
> On 22-09-10 05:48PM, Mikhail wrote:
> > While testing limit patch I came across not very intuitive search
> > behaviour which was introduced in Jun, by my patch 364ac6fd6 as unwanted
> > side effect:
> > https://marc.gameoftrees.org/thread/1661526335.M168509P13612Q2199.html
> > 
> > To illustrate, tog current got repo:
> > 
> > /foo
> > it will point to
> > 2022-08-29 17132eaa
> > 
> > G (jump to the last commit)
> > n
> > it will jump back and point to next commit after 17132eaa, which contain
> > 'foo':
> > 2022-03-20 7a30b5cb
> > 
> > With inlined patch we trully respect currently selected commit and
> > start searching after it, so after we do 'G' we get 'no more matches'.
> > 
> > Thoughts?
> 
> Yes, I can confirm your findings and the diff fixes the problem. This is
> ok by me.

ok for me too

> I wonder if it might be more intuitive at some point to make log search
> behave like the diff view (and most other apps' search behaviour like
> vi(1), for example) and loop around when at the start/end of the buffer?

I'd love it, and also if the search started consistently from the
cursor position :)