On Mon, Nov 07, 2022 at 09:40:11PM +0100, Stefan Sperling wrote:
> This tests gotd by sending to empty repositories. Testing this use
> case this uncovered a couple of bugs in several places. I fixed
> some bugs directly on the main branch, and some bugs have outstanding
> fixes on this list I sent earlier today.
> 
> With all those changes, this new test is passing.
> 
> ok? (will commit on top of all the other changes once they are in)
 
Sometimes the test fails, tgzs attached.

Log:

idea:~/work/got$ doas make server-install
make -C gotctl install         
install -c -o root -g wheel  -m 555 gotctl /root/bin/gotctl
make -C gotd install
install -c   -o root -g wheel  -m 555 gotd /root/bin/gotd
make -C gotsh install
install -c -o root -g wheel  -m 555 gotsh /root/bin/gotsh
idea:~/work/got$ doas make server-regress 
make -C regress/gotd
==== test_repo_read ====
test_clone_basic ok

==== test_repo_write ====
test_send_basic ok

==== test_repo_write_empty ====
test_send_empty got-fetch-pack: object 1ff513c97948af15b03507638dea5b19fde684eb not found
got: fetch failed
got clone failed unexpectedly
test failed; leaving test data in /tmp/gotd-test-send_empty-mWSi6aez
*** Error 1 in target 'test_repo_write_empty' (ignored)

idea:~/work/got$ doas make server-regress 
make -C regress/gotd
==== test_repo_read ====
test_clone_basic ok

==== test_repo_write ====
test_send_basic ok

==== test_repo_write_empty ====
test_send_empty ok

=======================================================================

Full make clean and make; make install; make server; doas make
server-install:

idea:~/work/got$ doas make server-regress                                                                                 17:16:36 [7/4904]
make -C regress/gotd           
==== test_repo_read ====                                                                                                                   
test_clone_basic ok
                                  
==== test_repo_write ====                                            
test_send_basic ok                                                   

==== test_repo_write_empty ====
test_send_empty ok

idea:~/work/got$ doas make server-regress 
make -C regress/gotd
==== test_repo_read ====
test_clone_basic ok

==== test_repo_write ====
test_send_basic ok

==== test_repo_write_empty ====
test_send_empty ok

idea:~/work/got$ doas make server-regress 
make -C regress/gotd
==== test_repo_read ====
test_clone_basic ok

==== test_repo_write ====
test_send_basic ok

==== test_repo_write_empty ====
test_send_empty ok

idea:~/work/got$ doas make server-regress 
make -C regress/gotd
==== test_repo_read ====
test_clone_basic ok

==== test_repo_write ====
test_send_basic ok

==== test_repo_write_empty ====
test_send_empty got-fetch-pack: object 14a636bcc4c16fff50809cfa8300cf142514789e not found
got: fetch failed
got clone failed unexpectedly
test failed; leaving test data in /tmp/gotd-test-send_empty-ejqmVN7z
*** Error 1 in target 'test_repo_write_empty' (ignored)

• gotd-test-send_empty-ejqmVN7z.tgz (22K)
• gotd-test-send_empty-mWSi6aez.tgz (22K)