"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: fix gotd group auth
To:
Omar Polo <op@omarpolo.com>
Cc:
gameoftrees@openbsd.org
Date:
Thu, 17 Nov 2022 11:17:06 +0100

Download raw body.

Thread
On Thu, Nov 17, 2022 at 11:05:27AM +0100, Omar Polo wrote:
> > +	struct passwd *pw;
> > +	gid_t groups[NGROUPS_MAX];
> > +	int ngroups;
> 
> ngroups should be initialized to NGROUPS_MAX, isn't it?  I get "group
> membership list truncated" otherwise, probably because luckily it gets
> zeroe'd at -O0

Good catch, thanks!