"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

Stefan Sperling <stsp@stsp.name>
Re: fix gotd_imsg_flush()
Omar Polo <op@omarpolo.com>
Sat, 3 Dec 2022 17:04:19 +0100

Download raw body.

On Sat, Dec 03, 2022 at 04:55:54PM +0100, Omar Polo wrote:
> On 2022/12/03 15:36:50 +0100, Stefan Sperling <stsp@stsp.name> wrote:
> > On a repository with more about 450 references, gotd fails to send
> > the initial reference announcement to clients because it runs into
> > an EAGAIN error from imsg_flush() during communication between
> > repo_read and the parent process.
> > 
> > This patch makes it work reliably by retrying queued messages when
> > imsg_flush() fails with EAGAIN.
> > 
> > ok?
> ok op@


> should we extend the check also for EWOULDBLOCK?  (although grepping
> shows that sometime we use EAGAIN, sometime the other spelling,
> curiously enough never both, and for -portable wasn't an issue AFAIK.)

I have no idea about this. Not sure if both names exist everywhere.
I guess if using just one of them is a problem we will find out eventually.