"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Omar Polo <op@omarpolo.com>
Subject:
gotwebd: fix navigation in commits page
To:
gameoftrees@openbsd.org
Date:
Fri, 16 Dec 2022 19:34:58 +0100

Download raw body.

Thread
tracey spotted the issue while testing my new diff.  Apparently, I
made a typo in 8d02314 that made the navigation links in the `commits'
page completely broken.

The typo is using COMMIT (which is defined for the querystring)
instead of COMMITS (the actual action name.)  I've reviewed the other
(three) instances of "COMMIT" and this seems to be only place where I
got it wrong.

Will try to remember to test the commits page too when hacking on
gotwebd, sorry for breaking the page.

ok?

diff /home/op/w/got
commit - ed619ca07e51b9c984c8404ca2b1153efdb14d1e
path + /home/op/w/got
blob - 0ce90275bab1028c73efcf66d2d59a727f7ca7c7
file + gotwebd/gotweb.c
--- gotwebd/gotweb.c
+++ gotwebd/gotweb.c
@@ -723,7 +723,7 @@ gotweb_render_navs(struct request *c)
 		if (t->prev_id && qs->commit != NULL &&
 		    strcmp(qs->commit, t->prev_id) != 0) {
 			struct gotweb_url url = {
-				.action = COMMIT,
+				.action = COMMITS,
 				.index_page = -1,
 				.page = qs->page - 1,
 				.path = qs->path,
@@ -792,7 +792,7 @@ gotweb_render_navs(struct request *c)
 	case COMMITS:
 		if (t->next_id) {
 			struct gotweb_url url = {
-				.action = COMMIT,
+				.action = COMMITS,
 				.index_page = -1,
 				.page = qs->page + 1,
 				.path = qs->path,