"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

Stefan Sperling <stsp@stsp.name>
Re: got patch: delete binary files too
Omar Polo <op@omarpolo.com>
Sat, 31 Dec 2022 18:07:15 +0100

Download raw body.

On Sat, Dec 31, 2022 at 05:51:16PM +0100, Omar Polo wrote:
> CVS patches will now be recognized and will fail (the extracted
> filename will be "/tmp/cvs...".)  We could read the Index line, which
> POSIX patch(1) handles but neither Larry' nor GNU patch honour by
> default, and somehow use it.  Maybe hardcoding some logic for rcs/cvs
> diffs.

Yeah, the way cvs displays a useless temporary file path is stupid.
And I see how this makes it harder to handle /usr/bin/diff output, too.

> Will try to add this logic as a follow-up commit if diff below
> is still ok.

Your diff is still fine, of course.
We can always improve things later if we want to.